Add support for custom ProcessingRecipeParams in basin recipes
#9070
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- add support for custom ProcessingRecipeParams in AbstractBasinRecipe by extending ProcessingRecipe instead of StandardProcessingRecipe - make BasinRecipe extend AbstractBasinRecipe, move most of its functionality - for basic Basin recipes
- add type parameter to BasinCategory (JEI) - move basin recipe type definition to BasinRecipe
|
@dudek26, this pull request has merge conflicts with the target branch. Please merge the latest changes and leave a message here so we can continue with the process of reviewing and merging this pull request. Thanks! |
# Conflicts: # src/main/java/com/simibubi/create/content/processing/basin/BasinRecipe.java
|
conflicts should be resolved now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My solution for #9066:
BasinRecipefunctionality to a newAbstractBasinRecipeclass, which is an extension ofProcessingRecipeinstead ofStandardProcessingRecipeand has<P extends ProcessingRecipeParams>type parameter.BasinRecipe.BuilderandBasinRecipe.Serializer(basin equivalents ofStandardProcessingRecipe's builder and serializer).<R extends AbstractBasinRecipe<?>>type parameter toBasinCategoryfor basin recipes with custom parameters.Compatibility issues:
BasinRecipeno longer extendsStandardProcessingRecipe, addons would have to update their custom recipe types' registration methods.BasinCategorywould have to specify the new type parameter.Other than that, I tried to make the changes as compatible as possible.
AbstractBasinRecipe's static methods could still be accessed viaBasinRecipe. Recipes that don't require customProcessingRecipeParamscould extendBasinRecipeand use generators provided by API, while addons would be able useAbstractBasinRecipefor basin recipes with custom parameters.